Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed and refactored Java SDK samples #11

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed and refactored Java SDK samples #11

wants to merge 2 commits into from

Conversation

samsonych
Copy link

@samsonych samsonych commented Jan 4, 2020 •
edited
Loading

Checklist

Pull Request Details

  • renamed samples artifact id to facebook-java-business-sdk-samples;
  • added the missed package to examples classes;
  • refactored the ExampleConfig class (reused the API context from the ExampleConfig class).

Test Plan

  • regenerate the facebook sdk code for java;
  • add the facebook-java-business-sdk-samples artifact as a maven module;
  • check a valid of compile the samples.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 4, 2020
@samsonych
Fixed and refactored Java SDK samples
36703b7 
- Moved media resources to the src/main/resources folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingping2015 jingping2015 Awaiting requested review from jingping2015

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonych @facebook-github-bot