Refactor logged_on_user_sid to support Windows Server 2019 #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In its current state, the returns on Windows Server 2019 because the is searching for a registry value that doesn't exist in that version of the operating system. To fix this, the code is being refactored to use PowerShell command to retrieve the SID of the current logged in user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In its current state,
CPE::Helpers.logged_on_user_sidreturnsnilon Windows Server 2019 becauseCPE::Helpers.logged_on_user_sidis searching for a registry valueLastLoggedOnUserSIDinCPE::Helpers.logged_on_user_registrythat doesn't exist in that version of the operating system. To fix this, the code is being refactored to use PowerShell command to retrieve the SID of the current logged in user. This code also works with earlier versions of Windows Server and Windows 10 endpoints.What type of PR is this?
/kind bug
What this PR does / why we need it:
Without this, Windows Server 2019 will return
nilfor CPE::Helpers.logged_on_user_sidWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This will require a Windows Server 2019 host to test on
Does this PR introduce a user-facing change?:
Additional documentation e.g., Design Proposals, usage docs, etc.: