Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating rights to support non-English OSs #271

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updating rights to support non-English OSs #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions itchef/cookbooks/cpe_chrome/resources/cpe_chrome_win.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,9 +284,9 @@
"#{prefix}\\Google\\Chrome\\Application",
].each do |dir|
directory dir do # ~FB024
rights :read, 'Everyone', :applies_to_children => true
rights :read_execute, 'Users', :applies_to_children => true
rights :full_control, ['Administrators', 'SYSTEM'],
rights :read, 'S-1-1-0', :applies_to_children => true # Everyone
rights :read_execute, 'S-1-5-32-545', :applies_to_children => true # Users
rights :full_control, ['S-1-5-32-544', 'S-1-5-18'], # [Administrators, SYSTEM]
:applies_to_children => true
action :create
end
Expand All @@ -307,9 +307,9 @@
)
}
path pref_path
rights :read, 'Everyone', :applies_to_children => true
rights :read_execute, 'Users', :applies_to_children => true
rights :full_control, ['Administrators', 'SYSTEM'],
rights :read, 'S-1-1-0', :applies_to_children => true # Everyone
rights :read_execute, 'S-1-5-32-545', :applies_to_children => true # Users
rights :full_control, ['S-1-5-32-544', 'S-1-5-18'], # [Administrators, SYSTEM]
:applies_to_children => true
action :create
end
Expand Down
2 changes: 1 addition & 1 deletion itchef/cookbooks/fb_helpers/libraries/node_methods.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,7 +767,7 @@ def root_group
# both, but Cookstyle will tell us `macos` isn't valid.
value_for_platform(
%w{openbsd freebsd mac_os_x macos} => { 'default' => 'wheel' },
'windows' => { 'default' => 'Administrators' },
'windows' => { 'default' => 'S-1-5-32-544' }, # Administrators
'default' => 'root',
)
end
Expand Down