Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2510: Yaml containing aliases rejected due to FasterXML bug #2646

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Dec 2, 2020

Fix #2510
Modify the way we deserialize Yaml objects. Load them into raw HashMap
using SnakeYAML and then use Jackson to convert them to JSON and finally
the required object

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa
Copy link
Member

manusa commented Dec 10, 2020

Since we want a consistent, deterministic behavior maybe instead of a fallback approach we could try something like:

Deserialization

  • Load YAML into an untyped object using SnakeYaml.
  • Serialize YAML into JSON
  • Use Jackson to deserialize the JSON into the final type

This way we will always take advantage of custom deserializers specified with Jackson Annotations.

Serialization
No bug was reported for this process. I would really don't touch this.

  • Object is serialized into YAML using Jackson

@rohanKanojia rohanKanojia marked this pull request as ready for review December 11, 2020 07:06
… bug

Modify the way we deserialize Yaml objects. Load them into raw HashMap
using SnakeYAML and then use Jackson to convert them to JSON and finally
the required object
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@manusa
Copy link
Member

manusa commented Dec 11, 2020

[merge]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yaml containing aliases rejected due to FasterXML bug
4 participants