-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2510: Yaml containing aliases rejected due to FasterXML bug #2646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Dec 2, 2020
rohanKanojia
force-pushed
the
pr/issue2510
branch
from
December 2, 2020 17:05
8bc94e1
to
db4b6ce
Compare
manusa
reviewed
Dec 10, 2020
kubernetes-client/src/main/java/io/fabric8/kubernetes/client/utils/Serialization.java
Outdated
Show resolved
Hide resolved
manusa
reviewed
Dec 10, 2020
kubernetes-client/src/main/java/io/fabric8/kubernetes/client/utils/Serialization.java
Outdated
Show resolved
Hide resolved
Since we want a consistent, deterministic behavior maybe instead of a fallback approach we could try something like: Deserialization
This way we will always take advantage of custom deserializers specified with Jackson Annotations. Serialization
|
rohanKanojia
force-pushed
the
pr/issue2510
branch
from
December 11, 2020 07:02
db4b6ce
to
a7d65db
Compare
manusa
reviewed
Dec 11, 2020
kubernetes-client/src/main/java/io/fabric8/kubernetes/client/utils/Serialization.java
Outdated
Show resolved
Hide resolved
manusa
approved these changes
Dec 11, 2020
… bug Modify the way we deserialize Yaml objects. Load them into raw HashMap using SnakeYAML and then use Jackson to convert them to JSON and finally the required object
rohanKanojia
force-pushed
the
pr/issue2510
branch
from
December 11, 2020 09:18
a7d65db
to
db1923b
Compare
Kudos, SonarCloud Quality Gate passed! |
[merge] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2510
Modify the way we deserialize Yaml objects. Load them into raw HashMap
using SnakeYAML and then use Jackson to convert them to JSON and finally
the required object
Description
Type of change
test, version modification, documentation, etc.)
Checklist