-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
healthcheck support in docker-compose configuration #1825
healthcheck support in docker-compose configuration #1825
Conversation
6872407
to
4af1ed1
Compare
@StasShymov : Hello, do you think changes in this pull request collide with #1736 (it's a draft PR that was created some time ago but author didn't get time to fix it) ? |
@rohanKanojia yes, partially
|
4ffd6ee
to
71a1f3e
Compare
9133596
to
5265b05
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1825 +/- ##
============================================
+ Coverage 65.87% 66.24% +0.37%
- Complexity 2306 2346 +40
============================================
Files 172 174 +2
Lines 10194 10342 +148
Branches 1408 1434 +26
============================================
+ Hits 6715 6851 +136
- Misses 2926 2928 +2
- Partials 553 563 +10
|
5265b05
to
d627688
Compare
@rohanKanojia is there anything I can do to help this patch go through? |
@StasShymov : Let me try to get this merged this weekend. |
import java.util.Map; | ||
import java.util.Properties; | ||
import java.util.Set; | ||
import java.util.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please revert these wildcard import changes?
@StasShymov : Is it possible to write an integration test for this functionality? I see there are integration tests for docker-compose in |
b6c8e3d
to
ca38e86
Compare
9f5f2b9
to
335f804
Compare
@rohanKanojia I updated the one that already exists, does it look ok to you? |
335f804
to
612e1d5
Compare
Quality Gate passedIssues Measures |
I confirmed that |
@StasShymov : Thanks a lot! |
healthcheck
configuration supportstartContainerWaitTimeout
configuration option