-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Automatically create parent directories of portPropertyFile path #1761
Feat: Automatically create parent directories of portPropertyFile path #1761
Conversation
b739b84
to
8a91d91
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1761 +/- ##
============================================
+ Coverage 65.75% 65.76% +0.01%
Complexity 2295 2295
============================================
Files 172 172
Lines 10181 10184 +3
Branches 1405 1406 +1
============================================
+ Hits 6695 6698 +3
Misses 2934 2934
Partials 552 552
|
@Willena : Hello, do you think it's a good idea to always create parent directories by default? |
My initials thought were to add a new parameter set to "false" by default to avoid changing the current behaviour (do not create paths). This should be (unless I forgot something) the current behaviour in the PR. That beeing said I would personnaly prefer that the plugin always try to create parent paths (and thus I can remove the option and simplifies the code). |
@Willena : It's good to be defensive. Your changes look good to me. However, I get the feeling that exposing a new configuration parameter just to ensure whether parent directory of |
8a91d91
to
b67c433
Compare
I fully agree with you. I've updated the PR to remove the option. Parent directories are now always created. |
@Willena : Thanks! Could you please add a line to doc/changelog.md regarding this change? |
b67c433
to
7266c11
Compare
Done ! |
Signed-off-by: Guillaume Villena <[email protected]>
7266c11
to
4db1e84
Compare
Quality Gate passedIssues Measures |
This adds a new option enabling automatic folder creation for the path specified in
portPropertyFile
.