fix(language-server): made xml parser async, updates language server,…

… adds notification handler

package.json

@@ -32,11 +32,12 @@
   "dependencies": {
     "request": "^2.79.0",
     "stream-json": "0.4.2",
-    "vscode-languageserver": "^2.2.0",
+    "vscode-languageserver": "^4.1.3",
     "winston": "2.3.1",
     "xml2object": "0.1.2"
   },
   "devDependencies": {
+    "@types/node": "^6.0.52",
     "@krux/condition-jenkins": "1.0.1",
     "semantic-release": "8.2.0",
     "typescript": "^2.1.4"

src/collector.ts

@@ -186,16 +186,21 @@ class NaivePomXmlSaxParser {
             // the XML document doesn't have to be well-formed, that's fine
             parser.error = null;
         });
+        parser.on("end", function () {
+            // the XML document doesn't have to be well-formed, that's fine
+            // parser.error = null;
+            this.dependencies = deps;
+        });
         return parser
     }
 
-    parse(): Array<IDependency> {
-        try {
-            this.stream.pipe(this.parser.saxStream);
-        } catch (e) {
-            console.error(e.message)
-        }
-        return this.dependencies
+    async parse() {
+        return new Promise(resolve => {
+            this.stream.pipe(this.parser.saxStream).on('end', (data) => {
+                resolve(this.dependencies);
+           });
+        });
+
     }
 }
 
@@ -204,8 +209,11 @@ class PomXmlDependencyCollector {
 
     async collect(file: Stream): Promise<Array<IDependency>> {
         let parser = new NaivePomXmlSaxParser(file);
-        let dependencies: Array<IDependency> = parser.parse();
-        return dependencies;
+        let dependencies;
+         await parser.parse().then(data => {
+            dependencies = data;
+        });
+        return dependencies || [];
     }
 }
 

src/server.ts

@@ -244,11 +244,17 @@ files.on(EventStream.Diagnostics, "^package\\.json$", (uri, name, contents) => {
     /* Convert from readable stream into string */
     let stream = stream_from_string(contents);
     let collector = new DependencyCollector(null);
+    connection.sendNotification('caNotification', 'Analysing dependencies for any security vulnerability');
 
     collector.collect(stream).then((deps) => {
         let diagnostics = [];
         /* Aggregate asynchronous requests and send the diagnostics at once */
         let aggregator = new Aggregator(deps, () => {
+            if(diagnostics.length > 0) {
+                connection.sendNotification('caNotification', `Out of ${deps.length}, ${diagnostics.length} dependencies have vulnerabilities`);
+            } else {
+                connection.sendNotification('caNotification', `Out of ${deps.length}, No dependencies have vulnerabilities`);
+            }
             connection.sendDiagnostics({uri: uri, diagnostics: diagnostics});
         });
         const regexVersion = new RegExp(/^(\d+\.)?(\d+\.)?(\d+)$/);
@@ -272,11 +278,17 @@ files.on(EventStream.Diagnostics, "^pom\\.xml$", (uri, name, contents) => {
     /* Convert from readable stream into string */
     let stream = stream_from_string(contents);
     let collector = new PomXmlDependencyCollector();
+    connection.sendNotification('caNotification', 'Analysing dependencies for any security vulnerability');
 
     collector.collect(stream).then((deps) => {
         let diagnostics = [];
         /* Aggregate asynchronous requests and send the diagnostics at once */
         let aggregator = new Aggregator(deps, () => {
+            if(diagnostics.length > 0) {
+                connection.sendNotification('caNotification', `Out of ${deps.length}, ${diagnostics.length} dependencies have vulnerabilities`);
+            } else {
+                connection.sendNotification('caNotification', `Out of ${deps.length}, No dependencies have vulnerabilities`);
+            }
             connection.sendDiagnostics({uri: uri, diagnostics: diagnostics});
         });
         const regexVersion = /^((\d+|[A-Za-z]+)[-.])*((\d+|[A-Za-z]+))$/