Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added and modified synonym file #51

Merged
merged 1 commit into from
Jan 23, 2018

Conversation

sunilk747
Copy link
Contributor

No description provided.

@sunilk747 sunilk747 requested a review from sara-02 January 23, 2018 10:53
@centos-ci
Copy link
Collaborator

@sunilk747 Your image is available in the registry: docker pull registry.devshift.net/fabric8-analytics/license-analysis:SNAPSHOT-PR-51

Copy link
Contributor

@sara-02 sara-02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally.

@sara-02 sara-02 merged commit 942d1a7 into fabric8-analytics:master Jan 23, 2018
@@ -211,7 +209,7 @@
"Modified BSD License": "bsd-new",
"Python style": "unknown",
"Common Public License Version 1.0": "cpl 1.0",
"MPL 2.0 or EPL 1.0": "unknown",
"MPL 2.0 or EPL 1.0": "mpl 2.0",
Copy link
Contributor

@miteshvp miteshvp Jan 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a random comment, but I feel that we should have lowercase letters for everything here and should be handled via program. In this way we can avoid something like
MPL 2.0 or EPL 1.0 -> mpl 2.0
mpl 2.0 or epl 1.0 -> mpl 2.0
Mpl 2.0 or Epl 1.0 -> mpl 2.0
Note - This applies to all the keys -> value here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miteshvp Yes, we have had this discussion before, we have to modify this file to all things lower case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I had the same discussion with sara yesterday. If we convert all the input licenses names into lowercase before passing it to our platform that way we can reduce the list of synonyms.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miteshvp #52 we can track it here. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants