-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added and modified synonym file #51
Conversation
@sunilk747 Your image is available in the registry: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested locally.
@@ -211,7 +209,7 @@ | |||
"Modified BSD License": "bsd-new", | |||
"Python style": "unknown", | |||
"Common Public License Version 1.0": "cpl 1.0", | |||
"MPL 2.0 or EPL 1.0": "unknown", | |||
"MPL 2.0 or EPL 1.0": "mpl 2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a random comment, but I feel that we should have lowercase letters for everything here and should be handled via program. In this way we can avoid something like
MPL 2.0 or EPL 1.0 -> mpl 2.0
mpl 2.0 or epl 1.0 -> mpl 2.0
Mpl 2.0 or Epl 1.0 -> mpl 2.0
Note - This applies to all the keys -> value here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miteshvp Yes, we have had this discussion before, we have to modify this file to all things lower case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I had the same discussion with sara yesterday. If we convert all the input licenses names into lowercase before passing it to our platform that way we can reduce the list of synonyms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.