Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hyperparams in stack report. #114

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lucky-suman
Copy link
Contributor

Adding hyperparameters for Maven and PyPI ecosystem.

@centos-ci
Copy link
Collaborator

@lucky-suman Your image is available in the registry: docker pull quay.io/openshiftio/rhel-fabric8-analytics-f8a-stacks-report:SNAPSHOT-PR-114

@codecov-io
Copy link

Codecov Report

Merging #114 into master will increase coverage by 0.07%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   86.18%   86.26%   +0.07%     
==========================================
  Files           7        7              
  Lines         883      888       +5     
==========================================
+ Hits          761      766       +5     
  Misses        122      122
Impacted Files Coverage Δ
f8a_report/report_helper.py 87.9% <85.71%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7161f8e...0b84798. Read the comment docs.

@centos-ci
Copy link
Collaborator

@lucky-suman Your image is available in the registry: docker pull quay.io/openshiftio/rhel-fabric8-analytics-f8a-stacks-report:SNAPSHOT-PR-114

@@ -64,6 +64,16 @@ def __init__(self):
'PYPI_TRAINING_REPO', 'https://github.com/fabric8-analytics/f8a-pypi-insights')

self.emr_api = os.getenv('EMR_API', 'http://f8a-emr-deployment:6006')
self.maven_hyperparams = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the use of same default values as in for maven and pypi?

Copy link
Collaborator

@miteshvp miteshvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants