Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attestable Switch class #386

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Attestable Switch class #386

merged 4 commits into from
Nov 1, 2024

Conversation

niksu
Copy link
Contributor

@niksu niksu commented Oct 31, 2024

This PR adds the Attestable Switch class and related functionality.
A FABRIC Artifact will be added to demonstrate how to use this functionality.
The code added in this PR is derived from beta 2 of the CREASE prototype (http://crease.cs.iit.edu/) which has been stable for the last few weeks, which gives us confidence that it's safe to upstream to fablib.
Through this class FABRIC users, will have the option to use attestable switch features, but can also use this as a convenient wrapper for BMv2.

@kthare10
Copy link
Collaborator

kthare10 commented Oct 31, 2024

@niksu - Tests are passing in the workflow. So, I think that's okay.
However, could you please address the two failures noted in Git workflow?

  • Add documentation to the code in attestable_switch.py
  • Add an entry to ChangeLog.md about the changes made.

Copy link

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing

Copy link
Collaborator

@kthare10 kthare10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kthare10 kthare10 merged commit 8cf17e4 into fabric-testbed:main Nov 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants