Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docstrings to config module #371

Merged
merged 9 commits into from
Sep 20, 2024
Merged

Add docstrings to config module #371

merged 9 commits into from
Sep 20, 2024

Conversation

sajith
Copy link
Member

@sajith sajith commented Sep 17, 2024

Resolves #320. Docstring additions themselves are minimal. The bigger change is addition of an interrogate configuration, and a CI workflow to check docstring coverage.

Interrogate 1.7.0 reports that docstring coverage is at 92.6% (excluding tests, and old editor code). The CI workflow will report a failure if docstring coverage falls under this threshold. This is configured in [tools.interrogate] section of pyproject.toml.

@sajith sajith added the documentation Improvements or additions to documentation label Sep 17, 2024
@sajith sajith self-assigned this Sep 17, 2024
@coveralls
Copy link
Collaborator

coveralls commented Sep 17, 2024

Pull Request Test Coverage Report for Build 10912154515

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 17.627%

Totals Coverage Status
Change from base Build 10911076241: 0.02%
Covered Lines: 1387
Relevant Lines: 5679

💛 - Coveralls

@sajith sajith marked this pull request as ready for review September 17, 2024 22:37
Copy link
Collaborator

@kthare10 kthare10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sajith sajith merged commit 476c346 into main Sep 20, 2024
21 checks passed
@sajith sajith deleted the 320.config-docstrings branch September 20, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing function docstrings in fablib.config.config
3 participants