Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to request specific subnets for FabNetv* or FabNetv6Ext when available #360

Merged
merged 5 commits into from
Sep 3, 2024

Conversation

kthare10
Copy link
Collaborator

@kthare10 kthare10 commented Sep 3, 2024

Allow users to request specific subnets for FabNetv* or FabNetv6Ext when available
This is a request from Tom to enable users who have slice that needs a valid certificate, so would like to be able to get the same address every time they instantiate the slice.

@coveralls
Copy link
Collaborator

coveralls commented Sep 3, 2024

Pull Request Test Coverage Report for Build 10689134844

Details

  • 2 of 16 (12.5%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 17.549%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fabrictestbed_extensions/fablib/network_service.py 1 7 14.29%
fabrictestbed_extensions/fablib/interface.py 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
fabrictestbed_extensions/fablib/network_service.py 1 13.08%
Totals Coverage Status
Change from base Build 10582270194: -0.03%
Covered Lines: 1379
Relevant Lines: 5667

💛 - Coveralls

@kthare10 kthare10 requested review from paul-ruth and sajith September 3, 2024 19:14
@kthare10 kthare10 merged commit 7fc94da into main Sep 3, 2024
20 checks passed
@kthare10 kthare10 deleted the fabnet-subnet branch September 3, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to request specific subnets for FabNetv* or FabNetv6Ext when available
3 participants