Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List resources update #353

Merged
merged 8 commits into from
Jul 22, 2024
Merged

List resources update #353

merged 8 commits into from
Jul 22, 2024

Conversation

kthare10
Copy link
Collaborator

  • Invoke Orchestrator API only when needed
  • Add start/end for list_facility_ports

@kthare10 kthare10 requested a review from paul-ruth July 19, 2024 21:21
@kthare10 kthare10 self-assigned this Jul 19, 2024
@kthare10 kthare10 linked an issue Jul 19, 2024 that may be closed by this pull request
Optimize calls to list_resources #352
Closed
@coveralls
Copy link
Collaborator

coveralls commented Jul 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10048029863

Details

  • 1 of 19 (5.26%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 17.504%
Changes Missing Coverage Covered Lines Changed/Added Lines %
fabrictestbed_extensions/fablib/slice.py 0 7 0.0%
fabrictestbed_extensions/fablib/fablib.py 1 12 8.33%
Files with Coverage Reduction New Missed Lines %
fabrictestbed_extensions/fablib/slice.py 1 6.3%
fabrictestbed_extensions/fablib/fablib.py 1 21.95%
Totals Coverage Status
Change from base Build 9997173147: -0.07%
Covered Lines: 1350
Relevant Lines: 5585
💛 - Coveralls

@kthare10 kthare10 merged commit fbc3468 into main Jul 22, 2024
19 checks passed
@kthare10 kthare10 deleted the list-resources-update branch July 22, 2024 20:43
@kthare10 kthare10 mentioned this pull request Aug 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-ruth paul-ruth paul-ruth approved these changes

Assignees

@kthare10 kthare10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize calls to list_resources
3 participants
@kthare10 @coveralls @paul-ruth