Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing docstrings in facility_port module #347

Merged
merged 18 commits into from
Jul 9, 2024

Conversation

sajith
Copy link
Member

@sajith sajith commented Jun 29, 2024

Resolves #312.

I'm unsure about what to state about get_template_context() and render_template() methods. Leaving in draft state, but open to feedback.

@coveralls
Copy link
Collaborator

coveralls commented Jun 29, 2024

Pull Request Test Coverage Report for Build 9724242968

Details

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • 15 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 18.309%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fabrictestbed_extensions/fablib/facility_port.py 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
fabrictestbed_extensions/fablib/facility_port.py 15 40.22%
Totals Coverage Status
Change from base Build 9646708720: 0.01%
Covered Lines: 1166
Relevant Lines: 4704

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 29, 2024

Pull Request Test Coverage Report for Build 9724266814

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 18.309%

Files with Coverage Reduction New Missed Lines %
fabrictestbed_extensions/fablib/facility_port.py 8 40.22%
Totals Coverage Status
Change from base Build 9646708720: 0.01%
Covered Lines: 1166
Relevant Lines: 4704

💛 - Coveralls

Not quite sure how these are used or should be documented.  Leaving
them out for now.
@coveralls
Copy link
Collaborator

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9764183425

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 18.309%

Files with Coverage Reduction New Missed Lines %
fabrictestbed_extensions/fablib/facility_port.py 7 40.22%
Totals Coverage Status
Change from base Build 9646708720: 0.01%
Covered Lines: 1166
Relevant Lines: 4704

💛 - Coveralls

@sajith sajith marked this pull request as ready for review July 2, 2024 15:59
@sajith sajith requested review from paul-ruth and kthare10 July 2, 2024 16:00
Copy link
Collaborator

@kthare10 kthare10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sajith sajith merged commit 755984f into main Jul 9, 2024
19 checks passed
@sajith sajith deleted the 312.facility-port-docstrings branch July 9, 2024 02:59
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9850209176

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 18.319%

Files with Coverage Reduction New Missed Lines %
fabrictestbed_extensions/fablib/facility_port.py 7 40.22%
Totals Coverage Status
Change from base Build 9850155529: 0.01%
Covered Lines: 1167
Relevant Lines: 4705

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing function docstrings in fablib.facility_port
3 participants