Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI housekeeping #333

Closed
wants to merge 14 commits into from
Closed

CI housekeeping #333

wants to merge 14 commits into from

Conversation

sajith
Copy link
Member

@sajith sajith commented May 31, 2024 •
edited
Loading

  • Separate code signing checks and code formatting checks.
  • Use a custom comment in code signing warnings, since FABRIC requires GPG-signed commits.
  • Use current versions of actions (reason: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/).
  • Use current stable Python release where possible.
  • Use coverallsapp action to send coverage, not Python coveralls. The former appears to work more reliably.
  • Add Python 3.12 to test matrix. (Edit: we can't do this yet.)
  • Add macos13 (Intel) and macos-14 (ARM) runners.
  • Enable some workflows to be triggered manually.

@sajith sajith added the no changelog Causes to skip changelog checks in "checks" workflow label May 31, 2024
@sajith
Step back on Python 3.12
f3071f6 
We're not there yet. This is the problem:

> INFO: pip is looking at multiple versions of fabric-fim to determine which version is compatible with other requirements. This could take a while.
> ERROR: Ignored the following versions that require a different python version: 1.0.2 Requires-Python >=3.8,<3.12; 1.0.3 Requires-Python >=3.8,<3.12; 1.21.2 Requires-Python >=3.7,<3.11; 1.21.3 Requires-Python >=3.7,<3.11; 1.21.4 Requires-Python >=3.7,<3.11; 1.21.5 Requires-Python >=3.7,<3.11; 1.21.6 Requires-Python >=3.7,<3.11; 2.0.0 Requires-Python >=3.8,<3.12; 2.0.1 Requires-Python >=3.8,<3.12
> ERROR: Could not find a version that satisfies the requirement networkx-query>=2.0.0 (from fabric-fim) (from versions: 0.1.0, 1.0.0, 1.0.1)
> ERROR: No matching distribution found for networkx-query>=2.0.0
> Error: Process completed with exit code 1.
@coveralls
Copy link
Collaborator

coveralls commented May 31, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9322224998

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.6%) to 18.308%
Totals Coverage Status
Change from base Build 9303430979: -3.6%
Covered Lines: 1165
Relevant Lines: 4703
💛 - Coveralls

This was referenced May 31, 2024
Closed
Merged
@sajith
Copy link
Member Author

sajith commented May 31, 2024

Closing in favor of a new one.

@sajith sajith closed this May 31, 2024
@sajith sajith deleted the ci-housekeeping branch May 31, 2024 18:09
@sajith sajith restored the ci-housekeeping branch May 31, 2024 18:09
@sajith sajith deleted the ci-housekeeping branch May 31, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
no changelog Causes to skip changelog checks in "checks" workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sajith @coveralls