Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Al2s support #327

Merged
merged 8 commits into from
May 30, 2024
Merged

Al2s support #327

merged 8 commits into from
May 30, 2024

Conversation

kthare10
Copy link
Collaborator

Changes to support AL2S provisioning used by Fabfed
#325

@kthare10 kthare10 requested review from paul-ruth and sajith May 29, 2024 18:56
@kthare10
Copy link
Collaborator Author

@sajith - Not sure what's the issue with black. I don't see any errors when I run it in my local env both with python3.9 and python3.11

@sajith
Copy link
Member

sajith commented May 29, 2024

@kthare10 Do you have black 24 in your local environment? We upgraded from black 23 in #311...

You can run tox -e format so that the correct versions of black and isort will run.

@kthare10
Copy link
Collaborator Author

@sajith I seem to have the correct version.

(cli) RENCI_C02G902WML86:fabrictestbed-extensions kthare10$ tox -e format
format: install_deps> python -I -m pip install 'black==24.*' 'isort==5.*'
format: commands[0]> black fabrictestbed_extensions tests
All done! ✨ 🍰 ✨
39 files left unchanged.
format: commands[1]> isort fabrictestbed_extensions tests
  format: OK (7.41=setup[3.27]+cmd[3.68,0.46] seconds)
  congratulations :) (7.49 seconds)
(cli) RENCI_C02G902WML86:fabrictestbed-extensions kthare10$
(cli) RENCI_C02G902WML86:fabrictestbed-extensions kthare10$ git status
On branch al2s-support
Your branch is up to date with 'origin/al2s-support'.

nothing to commit, working tree clean
(cli) RENCI_C02G902WML86:fabrictestbed-extensions kthare10$
(cli) RENCI_C02G902WML86:fabrictestbed-extensions kthare10$
(cli) RENCI_C02G902WML86:fabrictestbed-extensions kthare10$ python --version
Python 3.11.6
(cli) RENCI_C02G902WML86:fabrictestbed-extensions kthare10$
(cli) RENCI_C02G902WML86:fabrictestbed-extensions kthare10$ pip list | grep black
black                      24.4.2

@sajith
Copy link
Member

sajith commented May 29, 2024

@kthare10 Huh, that is annoying. Let me look into that.

@sajith
Copy link
Member

sajith commented May 29, 2024

@kthare10 Oh now I know what is going on. :-)

The pull_request_target trigger causes the base of the branch (e9ceeac) to be checked out, not the HEAD of the branch, and there is code in the base that black do not like. I think only the signed commits check recommends using pull_request_target as the trigger.

I will do some clean up in a separate PR. For the purpose of this PR, we can treat black's output like noise.

@kthare10 kthare10 merged commit e7e51cf into rel1.7 May 30, 2024
16 checks passed
@kthare10 kthare10 deleted the al2s-support branch May 30, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants