Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typos #324

Merged
merged 1 commit into from
May 28, 2024
Merged

fixed typos #324

merged 1 commit into from
May 28, 2024

Conversation

niksu
Copy link
Contributor

@niksu niksu commented May 28, 2024

No description provided.

Copy link

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

@sajith
Copy link
Member

sajith commented May 28, 2024

@niksu Thank you! Good catches.

Do you think you will be able to sign the commits? FABRIC project policy requires GPG signed commits. Unfortunately we do not have publicly available documentation regarding this policy, as far as I know. I will go ahead and merge this PR if signing commits is a hassle for you.

@coveralls
Copy link
Collaborator

coveralls commented May 28, 2024

Pull Request Test Coverage Report for Build 9276798683

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 21.891%

Totals Coverage Status
Change from base Build 9008543552: -0.1%
Covered Lines: 1151
Relevant Lines: 4689

💛 - Coveralls

@niksu
Copy link
Contributor Author

niksu commented May 28, 2024

Thanks @sajith
I've signed the commit

@sajith sajith merged commit 076389b into fabric-testbed:main May 28, 2024
13 of 14 checks passed
@sajith
Copy link
Member

sajith commented May 28, 2024

@niksu Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants