Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes for adding/removing interfaces from network service #283

Merged

Conversation

abessiari
Copy link
Contributor

@abessiari abessiari commented Feb 2, 2024

  • catch exception in add_interface when interface is not in slice. This happens with a facility port
  • avoid key error by first checking for key subnets before update fablib_data
  • Tested by creating a slice with a single node, a network service and a facility port. Then I modified the slice by adding/removing a node
    Add/Remove Network Interfaces for Facility Ports #284

Copy link

github-actions bot commented Feb 2, 2024

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git commit -S --amend --no-edit) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

@coveralls
Copy link
Collaborator

coveralls commented Feb 2, 2024

Pull Request Test Coverage Report for Build 7779695397

  • -6 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 22.197%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fabrictestbed_extensions/fablib/network_service.py 0 6 0.0%
Totals Coverage Status
Change from base Build 7703994008: -0.02%
Covered Lines: 1159
Relevant Lines: 4655

💛 - Coveralls

@abessiari abessiari force-pushed the aes-fix-add-remove-interfaces branch from f1b57c1 to 3541aeb Compare February 5, 2024 04:45
@abessiari
Copy link
Contributor Author

@kthare10

Hi here is the PR as per your request.

@kthare10
Copy link
Collaborator

kthare10 commented Feb 5, 2024

@abessiari - I'll merge this PR. Please consider enabling signed commits for future commits on FABRIC as most of the repositories only allow signed commits.

Copy link
Collaborator

@kthare10 kthare10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kthare10 kthare10 merged commit c23ab43 into fabric-testbed:main Feb 5, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants