Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make slice_manager calls to use as_self #282

Merged
merged 1 commit into from
Jan 29, 2024
Merged

make slice_manager calls to use as_self #282

merged 1 commit into from
Jan 29, 2024

Conversation

kthare10
Copy link
Collaborator

Fix errors for SliceManager call to still use as_self

@kthare10 kthare10 requested a review from paul-ruth January 29, 2024 23:20
@kthare10 kthare10 added the no changelog Causes to skip changelog checks in "checks" workflow label Jan 29, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7703793092

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 22.221%
Totals Coverage Status
Change from base Build 7703691363: 0.0%
Covered Lines: 1159
Relevant Lines: 4650
💛 - Coveralls

@kthare10 kthare10 requested a review from sajith January 29, 2024 23:24
@kthare10 kthare10 merged commit 706cdfa into main Jan 29, 2024
13 of 14 checks passed
@kthare10 kthare10 deleted the slice-sharing branch January 29, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-ruth paul-ruth paul-ruth approved these changes

@sajith sajith Awaiting requested review from sajith

Assignees
No one assigned
Labels
no changelog Causes to skip changelog checks in "checks" workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kthare10 @coveralls @paul-ruth