Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor logging setup #266

Merged
merged 8 commits into from
Jan 2, 2024
Merged

Refactor logging setup #266

merged 8 commits into from
Jan 2, 2024

Conversation

sajith
Copy link
Member

@sajith sajith commented Dec 29, 2023

Resolves #263: refactor logging setup code such that it is called only once.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7358600821

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 19.917%

Totals Coverage Status
Change from base Build 7211333571: -0.08%
Covered Lines: 972
Relevant Lines: 4337

💛 - Coveralls

@sajith sajith self-assigned this Dec 29, 2023
@sajith sajith requested review from paul-ruth and kthare10 January 2, 2024 15:38
Copy link
Collaborator

@kthare10 kthare10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sajith sajith merged commit 07f7ab6 into main Jan 2, 2024
13 checks passed
@sajith sajith deleted the 263.logging-config branch January 2, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logging.basicConfig() is called twice
3 participants