Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use defaults for fabric hosts #260

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Use defaults for fabric hosts #260

merged 3 commits into from
Oct 30, 2023

Conversation

sajith
Copy link
Member

@sajith sajith commented Oct 27, 2023

Resolves #258.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 6694736556

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 19.983%
Totals Coverage Status
Change from base Build 6298836123: 0.2%
Covered Lines: 975
Relevant Lines: 4343
💛 - Coveralls

@sajith sajith marked this pull request as ready for review October 30, 2023 15:16
@sajith sajith requested review from paul-ruth and kthare10 October 30, 2023 15:17
kthare10
kthare10 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@kthare10 kthare10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sajith sajith merged commit 2acad32 into main Oct 30, 2023
12 checks passed
@sajith sajith deleted the 258.default-fabric-hosts branch October 30, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kthare10 kthare10 kthare10 approved these changes

@paul-ruth paul-ruth Awaiting requested review from paul-ruth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use defaults for FABRIC hosts
3 participants
@sajith @coveralls @kthare10