Skip to content

Commit

Permalink
update changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
kthare10 committed Sep 23, 2024
1 parent 258f62f commit bc587e6
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- FabNet user specified subnets (Issue [#361](https://github.com/fabric-testbed/fabrictestbed-extensions/issues/361))
- Renew Slice leaves the slivers in ActiveTicketed State (Issue [#364](https://github.com/fabric-testbed/fabrictestbed-extensions/issues/364))
- get_management_os_interface and get_dataplane_os_interfaces doesn't take into account IPv6 addresses. (Issue [#362](https://github.com/fabric-testbed/fabrictestbed-extensions/issues/362))
- Disable post boot config for renew (Issue [#373](https://github.com/fabric-testbed/fabrictestbed-extensions/issues/373))
- slice.renew() should pass **kwargs through to slice.submit() (Issue [#374](https://github.com/fabric-testbed/fabrictestbed-extensions/issues/374))
- node.execute() retry parameter is off-by-one (and/or misnamed) (Issue [#375](https://github.com/fabric-testbed/fabrictestbed-extensions/issues/375))


## [1.7.3] - 08/05/2024
### Fixed
Expand Down
5 changes: 3 additions & 2 deletions fabrictestbed_extensions/fablib/slice.py
Original file line number Diff line number Diff line change
Expand Up @@ -1610,7 +1610,7 @@ def delete(self):

self.topology = None

def renew(self, end_date: str = None, days: int = None):
def renew(self, end_date: str = None, days: int = None, **kwargs):
"""
Renews the FABRIC slice's lease to the new end date.
Expand All @@ -1632,7 +1632,7 @@ def renew(self, end_date: str = None, days: int = None):
end = datetime.strptime(end_date, "%Y-%m-%d %H:%M:%S %z")
days = (end - datetime.now(timezone.utc)).days

self.submit(lease_in_days=days, post_boot_config=False)
self.submit(lease_in_days=days, post_boot_config=False, **kwargs)

def build_error_exception_string(self) -> str:
"""
Expand Down Expand Up @@ -2154,6 +2154,7 @@ def submit(
lease_start_time: datetime = None,
lease_in_days: int = None,
validate: bool = False,
**kwargs,
) -> str:
"""
Submits a slice request to FABRIC.
Expand Down

0 comments on commit bc587e6

Please sign in to comment.