Skip to content

Commit

Permalink
Merge pull request #323 from fabric-testbed/321.remove-redundant-node…
Browse files Browse the repository at this point in the history
…-delete

Remove redundant `Node.delete()`
  • Loading branch information
sajith authored May 8, 2024
2 parents be3c7b7 + 1cca8ed commit af03216
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
5 changes: 3 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed
- Add Facility Port to allow adding multiple interfaces (Issue [#289](https://github.com/fabric-testbed/fabrictestbed-extensions/issues/289))
- validate_config errors out when config directory does not exist (Issue [#299](https://github.com/fabric-testbed/fabrictestbed-extensions/issues/299)
- create_ssh_config adds extra indentation (Issue [#300](https://github.com/fabric-testbed/fabrictestbed-extensions/issues/300)
- validate_config errors out when config directory does not exist (Issue [#299](https://github.com/fabric-testbed/fabrictestbed-extensions/issues/299))
- create_ssh_config adds extra indentation (Issue [#300](https://github.com/fabric-testbed/fabrictestbed-extensions/issues/300))
- Remove duplicate Node.delete() method (Issue [#321](https://github.com/fabric-testbed/fabrictestbed-extensions/issues/321))

## [1.6.4] - 2024-03-05

Expand Down
3 changes: 0 additions & 3 deletions fabrictestbed_extensions/fablib/node.py
Original file line number Diff line number Diff line change
Expand Up @@ -322,9 +322,6 @@ def render_template(self, input_string, skip: List[str] = ["ssh_command"]):

return output_string

def delete(self):
self.get_slice().get_fim_topology().remove_node(name=self.get_name())

def show(
self, fields=None, output=None, quiet=False, colors=False, pretty_names=True
):
Expand Down

0 comments on commit af03216

Please sign in to comment.