Skip to content

Commit

Permalink
Merge pull request #254 from fabric-testbed/housekeeping
Browse files Browse the repository at this point in the history
Housekeeping updates
  • Loading branch information
sajith authored Sep 25, 2023
2 parents 39f6b46 + cb77914 commit 8dd815b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 9 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fix an error in `Node.list_networks()` (Issue
[#239](https://github.com/fabric-testbed/fabrictestbed-extensions/issues/239),
PR [#241](https://github.com/fabric-testbed/fabrictestbed-extensions/pull/241))
- Honor wait_timeout in slice.submit()
([#253](https://github.com/fabric-testbed/fabrictestbed-extensions/pull/253))

### Added

Expand Down
12 changes: 3 additions & 9 deletions tests/integration/test_bastion_ssh.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,7 @@ def test_probe_bastion_host_no_username(self):
Test bastion with an empty username.
"""
fm = FablibManager(offline=True, bastion_username="")
self.assertRaises(
paramiko.ssh_exception.AuthenticationException, fm.probe_bastion_host
)
self.assertRaises(paramiko.ssh_exception.SSHException, fm.probe_bastion_host)

def test_probe_bastion_host_empty_key(self):
"""
Expand All @@ -37,9 +35,7 @@ def test_probe_bastion_host_empty_key(self):
keyfile = tempfile.NamedTemporaryFile()

fm = FablibManager(offline=True, bastion_key_filename=keyfile.name)
self.assertRaises(
paramiko.ssh_exception.AuthenticationException, fm.probe_bastion_host
)
self.assertRaises(paramiko.ssh_exception.SSHException, fm.probe_bastion_host)

def test_probe_bastion_host_bad_key(self):
"""
Expand All @@ -51,6 +47,4 @@ def test_probe_bastion_host_bad_key(self):
rsa_key.write_private_key_file(keyfile.name)

fm = FablibManager(offline=True, bastion_key_filename=keyfile.name)
self.assertRaises(
paramiko.ssh_exception.AuthenticationException, fm.probe_bastion_host
)
self.assertRaises(paramiko.ssh_exception.SSHException, fm.probe_bastion_host)

0 comments on commit 8dd815b

Please sign in to comment.