Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed janus throwing error when setting the count to 0 and applying/d… #146

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

abessiari
Copy link
Contributor

So now we return if count is 0 in_config_file is set false.
This will the place to get the nodes and uninstall janus ....
We can add that logic later and invoke the destroy hook ezra mentioned ...

    def _validate_resource(self, resource: dict):
        assert resource.get(Constants.LABEL)
        assert resource.get(Constants.RES_TYPE) in Constants.RES_SUPPORTED_TYPES
        assert resource.get(Constants.RES_NAME_PREFIX)
        creation_details = resource[Constants.RES_CREATION_DETAILS]

        # count was set to zero 
        if not creation_details['in_config_file']:
            # TODO HANDLE UNINSTALL OF JANUS ON NODES ...
            return

        assert resource.get(Constants.RES_COUNT, 1)
        assert resource.get(Constants.RES_IMAGE)
        self.logger.info(f"Validated:OK Resource={self.name} using {self.label}")

@xi-yang xi-yang merged commit fe52a29 into develop Aug 22, 2024
4 checks passed
@xi-yang xi-yang deleted the fix-janus-provider-issue-144 branch August 22, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants