Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove socket io #476

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Remove socket io #476

merged 1 commit into from
Jun 18, 2024

Conversation

oscgonfer
Copy link
Contributor

Removes socket.io

@oscgonfer oscgonfer requested a review from pral2a May 16, 2024 16:52
@oscgonfer oscgonfer self-assigned this May 16, 2024
pral2a
pral2a approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@pral2a pral2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not run the app locally to verify the end-to-end functionality. However, I can confirm that the application did not use the removed code and that it remained only a legacy.

@oscgonfer oscgonfer merged commit 7d84e8b into master Jun 18, 2024
1 check passed
@oscgonfer oscgonfer deleted the cleanup/remove-socket-io branch June 18, 2024 16:43
@oscgonfer oscgonfer mentioned this pull request Sep 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pral2a pral2a pral2a approved these changes

Assignees

@oscgonfer oscgonfer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oscgonfer @pral2a