Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refurbish/remove kits #457

Merged
merged 23 commits into from
Mar 18, 2024
Merged

Refurbish/remove kits #457

merged 23 commits into from
Mar 18, 2024

Conversation

oscgonfer
Copy link
Contributor

@oscgonfer oscgonfer commented Jan 17, 2024 •
edited
Loading

This is a WIP PR for the new refurbish branch. Mostly it does the following:

  • Avoids creating blueprints
  • Renames as much as possible kit to device (not on urls)
  • Consolidates utils, deviceutils, kitutils, and many other extra modules that had functions that did the same, but in separate places

There is still a bunch of TO-DOs:

After this PR is merged, we can work in a separate PR for the kit-list improvements and the health checks

@oscgonfer oscgonfer marked this pull request as draft January 17, 2024 14:59
@oscgonfer
Removing kits. Improve Device and functions
034b320
@oscgonfer
Capture TODOs in comments
2d3cf95
@oscgonfer
Remove tools from user profile
cf4357c
@oscgonfer
Add back to device button in kit edit page
5b57998
@oscgonfer
Remove duplicated dropdown option
1d0b584
@oscgonfer
Ensure map is loaded once it sets sensors
415dfac
@oscgonfer
Fix properties definitions for device, fulldevice
28a106e
@oscgonfer
Move parseDate to timeUtils. Add lastReading to sensor
4067148
@oscgonfer
Consolidate last_reading_at in timeUtils
8a67d03
@oscgonfer
Add legacy devices section to editKit page
d6e6837
@oscgonfer
Add section for hardwareName
0af0853
@oscgonfer
Add token and mac_address to device model
c98b697
@oscgonfer
Fix notify stopped publishing notification typo
3e5bb71
@oscgonfer
Edit Kit step 2 without setup tool
9609b06
@oscgonfer
Additional WIP changes on kitEdit page for legacy devices
29c717d
@oscgonfer
Remove deprecated scktool
2191e6c
@oscgonfer
Add hardware version to new legacy kit and final checks
2513b67
@oscgonfer
Fix in isLegacy function
690a16a
@oscgonfer oscgonfer self-assigned this Mar 3, 2024
@oscgonfer oscgonfer marked this pull request as ready for review March 3, 2024 17:46
@oscgonfer oscgonfer mentioned this pull request Mar 3, 2024
Closed
@oscgonfer oscgonfer merged commit 1a9d09f into master Mar 18, 2024
1 check passed
@oscgonfer oscgonfer deleted the refurbish/remove-kits branch March 18, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timcowlishaw timcowlishaw timcowlishaw approved these changes

@pral2a pral2a Awaiting requested review from pral2a

Assignees

@oscgonfer oscgonfer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oscgonfer @timcowlishaw