Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structured root folder #32

Closed
wants to merge 1 commit into from
Closed

Structured root folder #32

wants to merge 1 commit into from

Conversation

r-Dev03
Copy link
Contributor

@r-Dev03 r-Dev03 commented Oct 1, 2022

Altered root/ file structure, moved JavaScript files, CSS files, and any image files into their respective folders within the /Public folder. E.G index.js -> /Public/JS/index.js
Changed all current script and stylesheet links and all IMG src elements to accommodate the new file structure. Everything works as intended. @pacehutt it will not let me mark it as hacktoberfest.
#9

@r-Dev03
Copy link
Contributor Author

r-Dev03 commented Oct 1, 2022

it seems as though in a different PR these files were altered, there should be no issue, however, I do not know how to update my separate branch since it might run into errors due to the file structure change, any ideas @pacehutt?

@faaiz-space
Copy link
Owner

faaiz-space commented Oct 1, 2022

it seems as though in a different PR these files were altered, there should be no issue, however, I do not know how to update my separate branch since it might run into errors due to the file structure change, any ideas @pacehutt?

Hey @r-Dev03 we advise you to clone the repo again and make a new branch from the main branch then do the changes.

See if the site is working fine or not with the new folder structure...

After that make a PR and we will look into it.

Edit: You will not find option to add "Hacktoberfest" label as when we will merge your PR then we'll be adding the "hacktoberfest-accepted" label

@r-Dev03
Copy link
Contributor Author

r-Dev03 commented Oct 1, 2022

I have already confirmed that the current PR'S file changes still allow the site to work fine, however I guess to have it merged I will have to clone it again. Understood

@faaiz-space
Copy link
Owner

I have already confirmed that the current PR'S file changes still allow the site to work fine, however I guess to have it merged I will have to clone it again. Understood

Is the site working as the current deployment on our gh-pages?

@r-Dev03
Copy link
Contributor Author

r-Dev03 commented Oct 1, 2022

Without the recent PR changes yes, but it won't let me test it unless I clone it down again since the CSS file was changed with the old structure, I'll clone it down and redo the changes tonight, as for the hacktoberfest label do you apply that?

@faaiz-space
Copy link
Owner

Without the recent PR changes yes, but it won't let me test it unless I clone it down again since the CSS file was changed with the old structure, I'll clone it down and redo the changes tonight, as for the hacktoberfest label do you apply that?

Yes then please clone the recent branch and work✅
And yes we will add the label on merging your PR it'll then reflect on your Hacktoberfest Account.

@r-Dev03 r-Dev03 closed this Oct 2, 2022
@r-Dev03 r-Dev03 deleted the Root-Folder-Structure branch October 2, 2022 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants