Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structured root folder #14

Closed
wants to merge 1 commit into from
Closed

Structured root folder #14

wants to merge 1 commit into from

Conversation

r-Dev03
Copy link
Contributor

@r-Dev03 r-Dev03 commented Sep 24, 2022 •
edited
Loading

Altered root/ file structure, moved JavaScript files, CSS files, and any image files into their respective folders within the /Public folder. E.G index.js -> /Public/JS/index.js
Changed all current script and stylesheet links and all IMG src elements to accommodate the new file structure. Everything works as intended.

@faaiz-space
Copy link
Owner

Gotcha will review and merge it soon

@faaiz-space faaiz-space linked an issue Sep 26, 2022 that may be closed by this pull request
Structure the /root folder #9
Open
@r-Dev03
Copy link
Contributor Author

r-Dev03 commented Sep 27, 2022 •
edited
Loading

Plan on merging it soon? If there are any issues let me know

@faaiz-space
Copy link
Owner

Plan on merging it soon? If there are any issues let me know

Yes we are waiting for the Hacktoberfest to start... Just some open-source instincts 📸

@r-Dev03
Copy link
Contributor Author

r-Dev03 commented Sep 29, 2022

Ahh, I understand, it seems to start in October 1st, should I sign up as well?

@faaiz-space
Copy link
Owner

Ahh, I understand, it seems to start in October 1st, should I sign up as well?

Yes everyone should register, in case you are registering then again make a PR on 1st October with Hacktoberfest label so your PR will be counted in the event,
We will happily merge it after reviewing.🔜

@r-Dev03
Copy link
Contributor Author

r-Dev03 commented Sep 29, 2022

Ok, I'll go ahead and make another PR this coming Saturday, October 1st with the label of hacktoberfest, and look forward to seeing it get merged :D

@faaiz-space
Copy link
Owner

Ok, I'll go ahead and make another PR this coming Saturday, October 1st with the label of hacktoberfest, and look forward to seeing it get merged :D

Make sure that new merges have been done so do checkout again from the main branch✅

@r-Dev03 r-Dev03 closed this Oct 1, 2022
@r-Dev03 r-Dev03 mentioned this pull request Oct 1, 2022
Closed
@r-Dev03 r-Dev03 deleted the Root-Folder-Structure branch October 2, 2022 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Structure the /root folder
2 participants
@r-Dev03 @faaiz-space