[feat] 일반 피드 상세 읽기 모달 UI 구현 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- FeedWrapper depends on whether there is pathname value "p" or not - If pathname "p" value of browser navigation is existed, FeedWrapper render children props
- The folder name included "@" caused error when committing - The folder name to start "@" means slot router
- FeedWrapper depends on whether or not browser navigation has value of key "f" - ReadOnlyCommonFeed is only rendering from props information about common feed - FeedTextContent is rendering feed information (profile, content, username etc.)
…tContent Component
- not included server request logic
…ontend into feature/common-feed-read-modal
- added height, maxHeight props at Modal Component
- update useAutoResizeTextArea hook (not use row count, use scrollHeight)
❌ Deploy Preview for prostargram failed.
|
|
|
FeedCommentWriteInput 컴포넌트와 FeedReplyWriteInput 컴포넌트가 유사한 로직도 많고 공통된 훅을 사용하고 있어서 id: string | number;
placeholder?: string;
maxLength?: number;
onSubmit: (id: string | number, content: string) => void; |
|
구현했을 당시에는 두 컴포넌트 디자인적인 차이가 있어서 일단 구분을 해두었는데요! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request 요약
일반 피드에 대한 상세 읽기 모달창을 구현합니다.
작업 내용
FeedWrapper- 브라우저 navigator 주소창에f를 포함한 Query String이 있다면,childrenprops를 렌더링ReadOnlyCommonFeed- 일반 피드에 대한 읽기 전용 피드 컴포넌트Slide- 자식 요소들을 슬라이드 중 하나의 페이지로 렌더링FeedTextContent- 일반 피드 정보를 렌더링FeedCommentList- 해당 피드에 대한 댓글 들에 대한 리스트들을 렌더링FeedComment- 댓글 하나에 대한 정보를 렌더링FeedLikeBox- 해당 피드에 대한 좋아요, 댓글 수를 표시하는 컴포넌트FeedCommentWriteInput- 해당 피드에 대한 댓글을 작성하는input컴포넌트참고 사항
Modal컴포넌트 -maxWidth,height,maxHeightprops 추가관련 이슈