Rename arguments to match Python implementation

ezzatron · Apr 26, 2024 · efa5d8a · efa5d8a
1 parent 82a0b33
commit efa5d8a
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/src/lat_lon2n_E.ts b/src/lat_lon2n_E.ts
@@ -1,11 +1,11 @@
 export function lat_lon2n_E(
-  lat: number,
-  lon: number,
+  latitude: number,
+  longitude: number,
 ): [x: number, y: number, z: number] {
-  const sinLat = Math.sin(lat);
-  const cosLat = Math.cos(lat);
-  const sinLon = Math.sin(lon);
-  const cosLon = Math.cos(lon);
+  const sinLat = Math.sin(latitude);
+  const cosLat = Math.cos(latitude);
+  const sinLon = Math.sin(longitude);
+  const cosLon = Math.cos(longitude);
 
   return [cosLat * cosLon, cosLat * sinLon, sinLat];
 }
diff --git a/src/n_E2lat_lon.ts b/src/n_E2lat_lon.ts
@@ -2,7 +2,7 @@ export function n_E2lat_lon(
   x: number,
   y: number,
   z: number,
-): [lat: number, lon: number] {
+): [latitude: number, longitude: number] {
   const sinLat = z;
   const cosLat = Math.sqrt(y ** 2 + x ** 2);
   const cosLatSinLon = y;

diff --git a/test/nvector-test-api.ts b/test/nvector-test-api.ts
@@ -2,15 +2,15 @@ import { WebSocket } from "ws";
 
 export type NvectorTestClient = {
   lat_lon2n_E: (
-    lat: number,
-    lon: number,
+    latitude: number,
+    longitude: number,
   ) => Promise<[x: number, y: number, z: number]>;
 
   n_E2lat_lon: (
     x: number,
     y: number,
     z: number,
-  ) => Promise<[lat: number, lon: number]>;
+  ) => Promise<[latitude: number, longitude: number]>;
 
   close: () => void;
 };
@@ -25,10 +25,10 @@ export async function createNvectorTestClient(): Promise<NvectorTestClient> {
   });
 
   return {
-    async lat_lon2n_E(lat, lon) {
+    async lat_lon2n_E(latitude, longitude) {
       const [[x], [y], [z]] = await call<[[number], [number], [number]]>(
         "lat_lon2n_E",
-        { latitude: lat, longitude: lon },
+        { latitude, longitude },
       );
 
       return [x, y, z];