Remove unnecessary stack frame suffix #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
ezyang
added a commit
that referenced
this pull request
Apr 30, 2024
There's a bug in our current frame emission code where we emit three Dynamo frames. Actually, I think this is fixed in PyTorch main but there's legacy code still running it. Chop it off. Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: ff288d7e1465442cd10efbcdb64ea8e339841738 ghstack-comment-id: 2087103294 Pull Request resolved: #24
jamesjwu
reviewed
May 1, 2024
| && frame.name == target.1 | ||
| }) | ||
| { | ||
| frames.truncate(len - 3); |
There was a problem hiding this comment.
nit: truncate to target_frames.len() here
| @@ -23,6 +23,29 @@ pub struct ParseConfig { | |||
| pub custom_parsers: Vec<Box<dyn crate::parsers::StructuredLogParser>>, | |||
| } | |||
|
|
|||
| fn maybe_remove_suffix(frames: &mut Vec<FrameSummary>) { | |||
There was a problem hiding this comment.
I feel like you'd want to name this something more specific like maybe_remove_convert_frame_suffixes, or make the function more general by being able to pass in a list of target frames instead of hard coding it
ezyang
added a commit
that referenced
this pull request
May 1, 2024
Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: 1ebd007fc1fe0b91200e0083d1238a5317292c6c ghstack-comment-id: 2088607801 Pull Request resolved: #30
ezyang
added a commit
that referenced
this pull request
May 1, 2024
Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: 200a5aa7b8d6cdd24d76cb2e168df15e309c0c1a ghstack-comment-id: 2088607801 Pull Request resolved: #30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug in our current frame emission code where we emit three
Dynamo frames. Actually, I think this is fixed in PyTorch main but
there's legacy code still running it. Chop it off.
Signed-off-by: Edward Z. Yang [email protected]