Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateContent : inherit section #7

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bchoquet-heliopsis
Copy link
Contributor

I guess it can be considered a bug fix :

  • when creating content, the new object section was set to standard by default no matter what section its parent was. It is now inherited from its parent if not manually set.

I also fixed a bug of mine in the CreateSection handler :

  • when setting a section identifier and that section already exists, the section object instead of the sectionID was stored in the reference array.

{
$objectInformation['sectionID'] = $parentNode->object()->attribute( 'section_id' );
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remembering a similar case in ezpackage, if it isn't done already here it should also verify section id if provided and if it does not exist inherti from parent and write warning or throw.

@bchoquet-heliopsis
Copy link
Contributor Author

Et voilà !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants