Move behat.yml to behat.yml.dist #207
Conversation
|
review ping @andrerom @bdunogier |
|
Might make more sense to do this during build, but depends on a few things including how we deal with upgrades in the future. |
|
@andrerom: (on a side note, the test fail is due to the demo package naming) |
|
I don't have a strong preference. What @andrerom suggests makes a bit more sense, I think: what's on GIT is testable, and the distribution is not. On the other hand, given that we kind of encourage people to run from GIT, it kind of defeats the purpose of the renaming if we only do it for builds :( |
|
Returning a bit to this discussion, should we move in direction of having most of these kind of files as "dist"? Thinking of our files as distribution basically, to not conflict with project files. What do you think @bdunogier & @lolautruche ? |
|
gentle ping @andrerom @bdunogier @lolautruche :) |
| @@ -17,3 +17,6 @@ php ezpublish/console --env=behat assetic:dump | |||
|
|
|||
| echo "> Clear and warm up caches for behat env" | |||
| php ezpublish/console cache:clear --env=behat --no-debug | |||
|
|
|||
| echo "> Use default behat configuration" | |||
| cp behat.yml.dist behat.yml | |||
There was a problem hiding this comment.
@joaoinacio can instead use the c argument of behat for travis.yml, cleaner, easier to spot
joaoinacio
force-pushed
the
behat_yml_dist
branch
2 times, most recently
from
af5f5ae to
368cd5e
Compare
|
Is it expected that it fails, @joaoinacio ? That aside, +1. |
joaoinacio
force-pushed
the
behat_yml_dist
branch
from
368cd5e to
bf04e07
Compare
|
+1. also need this on ezplatform |
behat config can require changes to match the current environment (most notably the hostname/url),
as well as any other custom configurations.
For this reason, ideally it should be kept outside of git repo, and instead use a default/dist file
(much in the same way as ezpublish.yml)
This changes the file name, updates travis script accordingly, and updates .gitignore.