Improvements to Varnish configuration #180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code is different with Varnish 6, since if ttl+grace is expired, vcl_hit will not be called.
Adding cases for more than hit/miss, and adding whether varnish deems the content cacheable/uncacheable to aid in debugging cache headers.
Not using full path for includes also allows for VCL outside of /etc/varnish, for testing or more flexible configuration.
gquintard
reviewed
Apr 22, 2024
|
|
||
| client c1 { | ||
| txreq | ||
| rxresp |
There was a problem hiding this comment.
can we get an expect here, for the status, or maybe for the x-cache header?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm happy to see you're using Varnish, but it seems the VCL configuration is a bit outdated.
I've made a few commits I hope will be helpful.
Summary:
Lastly, I've added some simple varnishtest testcases, these can be ran with the varnishtest utility which comes in the same package as varnish, but it's most powerful when ran using the official docker image in CI.
The tests I've added are just one for checking that the configuration is correct, compiles and passes one requet, and one for demonstrating cookie handling, but more advanced tests can be made, for example to test purging and caching of specific requests and responses.
Please let me know what you think, and if you have inputs to this I'm happy to make changes to make it better for you.
TODO: