Fix lint #363
Merged
Fix lint #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Flint is already providing results! |
|
@Ilia-Kosenkov CI is failing here due to something about license note ══ Failed tests ════════════════════════════════════════════════════════════════
── Failure ('test-license_note.R:9:3'): LICENSE.note is generated properly ─────
Snapshot of code has changed:
old[15:21] vs new[15:21]
Name: extendr-macros
Repository: https://github.com/extendr/extendr
- Authors: andy-thomason, Thomas Down, Mossa Merhi Reimert, Claus O. Wilke, Hiroaki Yutani, Ilia A. Kosenkov
+ Authors: andy-thomason, Thomas Down, Mossa Merhi Reimert, Claus O. Wilke, Hiroaki Yutani, Ilia A. Kosenkov, Michael Milton
License: MIT
-------------------------------------------------------------
* Run `testthat::snapshot_accept('license_note')` to accept the change.
Error: Error: R CMD check found ERRORs
* Run `testthat::snapshot_review('license_note')` to interactively review the change.
|
Merged
|
Rebased. Should work now as the error in CI was fixed in #365. Approving when test is passed, because we have auto-merge on. |
Ilia-Kosenkov
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was just testing
flinton real packages and found this one, might as well fix it ;)