Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "update R CMD check to use binaries" #336

Merged
merged 2 commits into from
Jan 13, 2024
Merged

Revert "update R CMD check to use binaries" #336

merged 2 commits into from
Jan 13, 2024

Conversation

JosiahParry
Copy link
Contributor

Reverts #335

@JosiahParry
Copy link
Contributor Author

This is embarrassing! The checks passed. But quietly issues a note that it was an unexpected with parameter. I put it in the wrong action. This PR will revert and place in the appropriate location.

Ilia-Kosenkov
Ilia-Kosenkov approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@Ilia-Kosenkov Ilia-Kosenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I did not check it thoroughly as well.

@JosiahParry
Copy link
Contributor Author

Confirmed it worked as expected.

@JosiahParry JosiahParry merged commit c2fb7a4 into main Jan 13, 2024
19 checks passed
@JosiahParry JosiahParry mentioned this pull request Jan 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ilia-Kosenkov Ilia-Kosenkov Ilia-Kosenkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JosiahParry @Ilia-Kosenkov