-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add xx/changelog/index.md files for id & th #1685
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
These changes look good to me. Thanks for your contribution! |
My pleasure! If there's anything else regarding this issue, please let me know. I'm happy to try and help |
We should update the home in (th) |
Hi @carlosstenzel! Just wanted to confirm if the line below is what you were referring to:
If this is the correct line, I was wondering if I could have your advice on what I should change it to - I'm a little bit new to the project and want to follow the best practices/follow any existing examples! Edit: I can also the header-id.html file too |
Hi @peterdanwan |
Hey Carlo, what do you mean by this? Which part? |
That should be in another PR, and I don't think we should invest effort into that for now, Many home pages are a bit outdated |
c099619
to
a3e5024
Compare
Hi @chrisdel101, @carlosstenzel, @bjohansebas! I rebased my changes onto what's been added to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @peterdanwan, can you add the content from those two pages?, as i describe in my comment, The only link that should be in English is for the blog.
Hi @bjohansebas! Just want to confirm the exact files that need to be added. I can change revert both: <a href="/{{ page.lang }}/changelog/4x.html">Release Change Log</a> To make sure the href pointing to
Would this file ( |
The appropriate one would be |
Hi @bjohansebas, thanks for the quick response! I've added the file |
Yeah, also please remove |
- feat: add css/uz.css file - feat: add css/id.css file
a3e5024
to
1000b5e
Compare
Hi @bjohansebas, I added my changes and squashed them into one commit. Please let me know if there's anything you'd like me to change or modify! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @peterdanwan
Thanks @bjohansebas! Appreciate you taking the time to walk me through the process! |
PS: @bjohansebas please let me know if you want me to squash my commits into one |
It's not necessary, we always merge with the squash option for commits, so it happens automatically. btw, I need to wait a bit before merging into the main branch. |
Whoa, that's really cool! I got to look into that |
This PR:
[x] changes the link in_includes/header/header-th.html
:from:<a href="/{{ page.lang }}/changelog/4x.html">บันทึกการเปลี่ยนแปลง</a>
to:<a href="/en/changelog/">บันทึกการเปลี่ยนแปลง</a>
[x] changes the link in_includes/header/header-id.html
:<a href="/{{ page.lang }}/changelog/4x.html">Release Change Log</a>
~to:<a href="/en/changelog/">Release Change Log</a>
th/changelog/index.md
andid/changelog/index.md
, followingen/changelog/index.md
as an examplecss/uz.css
file, following the same styles ascss/tr.css
Demonstration of
http://localhost:4000/id/
Release Change Log link working:2024-11-17.15-00-17.mp4
Demonstration of
http://localhost:4000/th/
Release Change Log link working:2024-11-17.15-01-32.mp4