Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add xx/changelog/index.md files for id & th #1685

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

peterdanwan
Copy link
Contributor

@peterdanwan peterdanwan commented Nov 17, 2024

This PR:

  • [x] changes the link in _includes/header/header-th.html:
    • from: <a href="/{{ page.lang }}/changelog/4x.html">บันทึกการเปลี่ยนแปลง</a>
    • to: <a href="/en/changelog/">บันทึกการเปลี่ยนแปลง</a>
  • [x] changes the link in _includes/header/header-id.html:
    • ~from: <a href="/{{ page.lang }}/changelog/4x.html">Release Change Log</a> ~
    • to: <a href="/en/changelog/">Release Change Log</a>
  • adds th/changelog/index.md and id/changelog/index.md, following en/changelog/index.md as an example
  • adds the css/uz.css file, following the same styles as css/tr.css
  • attempts to close Broken link and missing page #1684

Demonstration of http://localhost:4000/id/ Release Change Log link working:

2024-11-17.15-00-17.mp4

Demonstration of http://localhost:4000/th/ Release Change Log link working:

2024-11-17.15-01-32.mp4

Copy link

netlify bot commented Nov 17, 2024

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit c498d47
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/675a091775fcbc00086475d3
😎 Deploy Preview https://deploy-preview-1685--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chrisdel101
Copy link
Contributor

These changes look good to me. Thanks for your contribution!
We'll have a few other members approve it and then it should be good to go.

@peterdanwan
Copy link
Contributor Author

These changes look good to me. Thanks for your contribution! We'll have a few other members approve it and then it should be good to go.

My pleasure! If there's anything else regarding this issue, please let me know. I'm happy to try and help

@carlosstenzel
Copy link
Contributor

We should update the home in (th)

@peterdanwan
Copy link
Contributor Author

peterdanwan commented Nov 20, 2024

We should update the home in (th)

Hi @carlosstenzel! Just wanted to confirm if the line below is what you were referring to:

<li><a href="/{{ page.lang }}/" id="home-menu"{% if page.menu == 'home' %} class="active"{% endif %}>หน้าแรก</a></li>

If this is the correct line, I was wondering if I could have your advice on what I should change it to - I'm a little bit new to the project and want to follow the best practices/follow any existing examples!

Edit: I can also the header-id.html file too

@carlosstenzel
Copy link
Contributor

Hi @peterdanwan
I refer to the page th/index.md
tks

@chrisdel101
Copy link
Contributor

chrisdel101 commented Nov 21, 2024

We should update the home in (th)

Hey Carlo, what do you mean by this? Which part?

@carlosstenzel
Copy link
Contributor

We should update the home in (th)

Hey Carlo, what do you mean by this? Which part?

the content

th
Captura de Tela 2024-11-21 às 17 28 31

en
Captura de Tela 2024-11-21 às 17 29 19

@bjohansebas
Copy link
Member

That should be in another PR, and I don't think we should invest effort into that for now, Many home pages are a bit outdated

@peterdanwan
Copy link
Contributor Author

Hi @chrisdel101, @carlosstenzel, @bjohansebas! I rebased my changes onto what's been added to gh-pages branch to make it easier to merge. Please let me know if there's anything else I can do for this PR

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @peterdanwan, can you add the content from those two pages?, as i describe in my comment, The only link that should be in English is for the blog.

@peterdanwan
Copy link
Contributor Author

Hi @bjohansebas! Just want to confirm the exact files that need to be added.

I can change revert both: _includes/header/header-th.html and _includes/header/header-id.html to how they were before:

<a href="/{{ page.lang }}/changelog/4x.html">Release Change Log</a>

To make sure the href pointing to /{{ page.lang }}/changelog/4x.html works, would I be creating the following files:

  • id/changelog/4x.md
  • th/changelog/4x.md

Would this file (tr/changelog/4x.md) be the appropriate file to reference?

image

@bjohansebas
Copy link
Member

The appropriate one would be en/changelog/index.md as it is the most recent and updated version of the changelog.

@peterdanwan
Copy link
Contributor Author

Hi @bjohansebas, thanks for the quick response!

I've added the file id/changelog/index.md, copying the contents from en/changelog/index.md.
I made slight modifications to the file - just wanted to confirm this is what I should be doing. If so, then I'll repeat that for th/changelog/index.md as well.

vscode-id

changelog-id

@bjohansebas
Copy link
Member

Yeah, also please remove /changelog/4x.html from the redirects.

- feat: add css/uz.css file
- feat: add css/id.css file
@peterdanwan peterdanwan changed the title fix: replace /{{ page.lang }}/changelog/4x.html with /en/changelog/ feat: add xx/changelog/index.md files for id & th Dec 11, 2024
@peterdanwan
Copy link
Contributor Author

Hi @bjohansebas, I added my changes and squashed them into one commit. Please let me know if there's anything you'd like me to change or modify!

th/changelog/index.md Outdated Show resolved Hide resolved
Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @peterdanwan

@peterdanwan
Copy link
Contributor Author

LGTM, thanks @peterdanwan

Thanks @bjohansebas! Appreciate you taking the time to walk me through the process!

@peterdanwan
Copy link
Contributor Author

PS: @bjohansebas please let me know if you want me to squash my commits into one

@bjohansebas
Copy link
Member

It's not necessary, we always merge with the squash option for commits, so it happens automatically.

btw, I need to wait a bit before merging into the main branch.

@peterdanwan
Copy link
Contributor Author

It's not necessary, we always merge with the squash option for commits, so it happens automatically.

btw, I need to wait a bit before merging into the main branch.

Whoa, that's really cool! I got to look into that

@bjohansebas bjohansebas merged commit 73e7ba9 into expressjs:gh-pages Dec 13, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link and missing page
4 participants