-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add netlify logo as per their OSS license requirements #1511
add netlify logo as per their OSS license requirements #1511
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Cool, previews work! the logo isn't aligned so this shouldn't land yet, someone else can run with it if they want |
The preview capability is great! Now I don't have to clone every fork/branch to see what it looks like--awesome! But I'd like to suggest:
What do you think? This is done in
|
LGTM And just to be clear (for posterity), we are still hosting the site and deploying via github pages Only previews are netlify, so "powered by netlify" isnt super true. We also have the option to provide a link to netlify if we prefer not to use their badge |
Add Netlify logo to footer as discussed
Moved Netlify logo to footer per discussion
OK, I made that change in your fork/branch @jonchurch . It was also a good trial of the deploy preview functionality. So nice. Notes:
|
I setup netlify deploy previews, part of their deal for OSS is we get a free Pro plan with unlimited seats, and they get a plug on our homepage