-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs]: Routing - timeLog
not defined
#1410
Conversation
Either have a function named `timeLog` or reword the last sentence of the page to remove the use of that name.
This looks right to me, but I'd like someone to confirm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @gregfenton, this improves the readability 👍
Remove EOL colons to conform with doc code style
The tests were failing because two lines of example code ended with colons. By convention, docs don't terminate code lines with colons. I edited the fork/branch directly so we can land this. |
Interesting that tests were failing because of valid code 😊 @crandmck Sorry for the trouble, and thank you for the fix. If there's a CONTRIBUTIONS set of instructions I missed, apologies for that. |
No worries @gregfenton Thanks for the contribution! |
Cool, thanks for that! Of course, this means that "fly by edits via GitHub UI" like I did are ... not inline with those standards. My bad. Cheers. |
Either have a function named
timeLog
or reword the last sentence of the page to remove the use of that name.