Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs]: Routing - timeLog not defined #1410

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

gregfenton
Copy link
Contributor

Either have a function named timeLog or reword the last sentence of the page to remove the use of that name.

Either have a function named `timeLog` or reword the last sentence of the page to remove the use of that name.
@crandmck crandmck self-requested a review March 5, 2024 03:03
@crandmck crandmck added the needs tech review A doc edit that requires technical review before merging label Mar 6, 2024
@crandmck
Copy link
Member

crandmck commented Mar 6, 2024

This looks right to me, but I'd like someone to confirm.

@crandmck crandmck requested a review from UlisesGascon March 6, 2024 23:05
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @gregfenton, this improves the readability 👍

Remove EOL colons to conform with doc code style
@crandmck
Copy link
Member

crandmck commented Mar 7, 2024

The tests were failing because two lines of example code ended with colons. By convention, docs don't terminate code lines with colons. I edited the fork/branch directly so we can land this.

@crandmck crandmck merged commit 9afb599 into expressjs:gh-pages Mar 7, 2024
1 check passed
@gregfenton
Copy link
Contributor Author

Interesting that tests were failing because of valid code 😊

@crandmck Sorry for the trouble, and thank you for the fix. If there's a CONTRIBUTIONS set of instructions I missed, apologies for that.

@crandmck
Copy link
Member

crandmck commented Mar 8, 2024

No worries @gregfenton Thanks for the contribution!
See https://expressjs.com/en/resources/contributing.html#collaborators-guide.
For semicolon usage, https://standardjs.com/rules#semicolons .

@gregfenton
Copy link
Contributor Author

Cool, thanks for that!

Of course, this means that "fly by edits via GitHub UI" like I did are ... not inline with those standards. My bad.

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs tech review A doc edit that requires technical review before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants