-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds docker-compose configuration #843
base: master
Are you sure you want to change the base?
Conversation
I'm very interested in this. Is this going to happen? |
Might have to revisit this. Could do without manning changes to the app |
I am learning it (as well as Git in general) and am looking at modifying this Dockerized version now: https://github.com/KryptedGaming/pathfinder-docker I've been reviewing the files and I see nothing nefarious but would prefer native support using MariaDB and Traefik for the native docker support and built-in Let's Encrypt functionality. |
You can also find some more Dockerfiles in my repo https://github.com/tralafiti/pathfinder Sadly didn't have time to move this into it's own repo / publish pre-build packages and it still uses mounts instead of volumes but it's running solid on my system including Maria, Redis, Websocket etc. |
Krypted Gaming has a very robust docker project for hosting pathfinder https://github.com/KryptedGaming/pathfinder-docker if you are interested in working on something like this, check it out. |
RUN chmod +x /root/entrypoint.sh | ||
RUN chmod 0766 /usr/share/nginx/html/logs | ||
|
||
ENTRYPOINT ["sh", "-c", "/root/entrypoint.sh"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
container failed to start. sh: /root/entrypoint.sh: not found
This PR will add a folder called .docker which contains files that will create images used in docker compose to spin up a full Pathfinder stack.
Some configurations have been changed so that the services communicate with each other properly in a docker environment. Note the changes in config.ini which point cache data to the
redis
container and changes the session cache to use the php handler.Environment.ini was changed to set the socket host to the
websocket
container.Readme.md was changed to add docker instructions.
The websocket was added as a submodule pointing to my fork. One change needs to be made to the tcpHost because it defaults to 127.0.0.1 which is not available outside a container. This can obviously be set using the
--tcpHost
argument.I would recommend merging this into a different branch because of the config changes but im new to doing PR's so if there are any recommendations i'm more than willing to make this work. I spent 8 hours getting it running stable so what's a few more to make sure it's viable as a good contribution.
I'm also in slack as stiforr if you have any questions.