sync clock #863
sync clock #863
Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
tomasnorre
added
x:action/sync
* fix: Ensure name_filter are local scoped * fix test on macos
| public function testOnTheHour(): void | ||
| { | ||
| $clock = new Clock(8); | ||
|
|
||
| $this->assertEquals('08:00', $clock->__toString()); | ||
| $this->assertEquals('08:00', $clock); |
There was a problem hiding this comment.
This is one of the magic tricks in PHP, but we currently have no concept (concept exercise) for students to learn this. So we should either explain the magic in the stub (for now) or explicitly call the method as done before:
| $this->assertEquals('08:00', $clock); | |
| $this->assertEquals('08:00', $clock->__toString()); |
or
| $this->assertEquals('08:00', $clock); | |
| $this->assertEquals('08:00', (string)$clock); | |
| // plus use `implements Stringable` in the students stub | |
| // plus a comment in the stub pointing to PHP docs on interface `Stringable` |
@homersimpsons What do you think about this?
Resolves #845