nucleotide-count: convert the class to a function #579
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before PR #550 the constructor was required to validate the input, the member function
count(char)
had to return the count for a specific nucleotide, the member functionnucleotide_counts()
had to return astd::map
with all four counts.But PR #550 has changed that significantly. After syncing the tests with the canonical data there's no call to
count(char)
anymore, so each test looks like a two-step function call:I'd call that unnecessarily complicated and unidiomatic, there's no longer a good reason to require a
class
. Let's turn the classcounter
into a function: