Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New client api performGenericRequest allows for custom graphql errors #5

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Matt-st
Copy link

@Matt-st Matt-st commented May 8, 2020

The GraphQL specification has gone through changes with regards to the error specification seen here. The specification refers to preferred and non preferred ways of representing errors. In the most recent specification update from 2018, extensions are used to hold extra information that organizations may need to make their error handling more robust. Many organizations have used GraphQL prior to the addition of extensions in 2018 and therefore have created custom Error objects for their GraphQL schema implementations. To make this graphql client more robust and gain the ability to handle GraphQL errors that don't follow the current specification I thought I would add a performGenericRequest that can handle custom error objects. Please review and share your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants