fix: allow entity names to be set at any time (#2775)

Fixes a minor annoyance where you cannot set an entities name after construction

CHANGELOG.md

@@ -30,7 +30,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Changed
 
--
+- Allow entity names to be set after construction! Entities will now default to a name "Entity#1234" followed by an id.
 
 <!--------------------------------- DO NOT EDIT BELOW THIS LINE --------------------------------->
 <!--------------------------------- DO NOT EDIT BELOW THIS LINE --------------------------------->

src/engine/EntityComponentSystem/Entity.ts

@@ -101,12 +101,18 @@ export class Entity implements OnInitialize, OnPreUpdate, OnPostUpdate {
   protected _setName(name: string) {
     if (name) {
       this._name = name;
+    } else {
+      this._name = `Entity#${this.id}`;
     }
   }
   public get name(): string {
     return this._name;
   }
 
+  public set name(name: string) {
+    this._setName(name);
+  }
+
   /**
    * Whether this entity is active, if set to false it will be reclaimed
    */

src/engine/Graphics/Context/debug-text.ts

@@ -24,14 +24,14 @@ export class DebugText {
       this._spriteSheet = SpriteSheet.fromImageSource({
         image: this._imageSource,
         grid: {
-          rows: 3,
+          rows: 4,
           columns: 16,
           spriteWidth: 16,
           spriteHeight: 16
         }
       });
       this._spriteFont = new SpriteFont({
-        alphabet: '0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ,!\'&."?-()+ ',
+        alphabet: '0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ,!\'&."?-()+# ',
         caseInsensitive: true,
         spriteSheet: this._spriteSheet,
         spacing: -6

src/spec/EntityManagerSpec.ts

@@ -80,7 +80,7 @@ describe('An EntityManager', () => {
     entityManager.addEntity(entity);
     entityManager.addEntity(entity2);
     expect(entityManager.getByName('some-e')).toEqual([entity]);
-    expect(entityManager.getByName('anonymous')).toEqual([entity2]);
+    expect(entityManager.getByName(entity2.name)).toEqual([entity2]);
   });
 
   it('can clear entities', () => {

src/spec/EntitySpec.ts

@@ -45,9 +45,15 @@ describe('An entity', () => {
     expect(e.name).toBe('my-name');
   });
 
+  it('can have a name set after construction', () => {
+    const e = new ex.Entity();
+    e.name = 'MyCoolName';
+    expect(e.name).toBe('MyCoolName');
+  });
+
   it('has a default name', () => {
     const e = new ex.Entity();
-    expect(e.name).toBe('anonymous');
+    expect(e.name).toMatch(/^Entity#\d+$/);
   });
 
   it('can be killed', () => {