#174: Added get_language_definition to the language container deployer #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkilias
changed the title
| @@ -213,6 +213,16 @@ def _update_previous_language_settings(self, alter_type: LanguageActivationLevel | |||
| path_in_udf, prev_lang_aliases) | |||
| return new_definitions_str | |||
|
|
|||
| def get_language_definition(self, bucket_file_path: str): | |||
There was a problem hiding this comment.
would it be cleaner to split _generate_new_language_settings into a function which generates the " other_definitions" and one which generates "new_language_alias_definition"? then we do not have to call with an empty list, but instead have one calling function calling both, and one only calling one?
There was a problem hiding this comment.
in general yes, but because we haven't extracted this code into a central place, yet, we need to manually copy changes to sagemaker-extension, for that reason, I would like to keep the changes simple for the moment
There was a problem hiding this comment.
alright. maybe add a comment or something to do later?
There was a problem hiding this comment.
will create a ticket
MarleneKress79789
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #174
All Submissions:
[CodeBuild]to the commit message