Skip to content

Commit

Permalink
Rename get_language_activation to get_language_definition
Browse files Browse the repository at this point in the history
  • Loading branch information
tkilias committed Jan 5, 2024
1 parent 8d572f6 commit ceb4245
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,12 @@ def _update_previous_language_settings(self, alter_type: LanguageActivationLevel
path_in_udf, prev_lang_aliases)
return new_definitions_str

def get_language_activation(self, bucket_file_path: str):
def get_language_definition(self, bucket_file_path: str):
"""
Generate a language definition (ALIAS=URL) for the specified bucket file path.
bucket_file_path - Path within the designated bucket where the container is uploaded.
"""
path_in_udf = self._bucketfs_location.generate_bucket_udf_path(bucket_file_path)
result = self._generate_new_language_settings(path_in_udf=path_in_udf, prev_lang_aliases=[])
return result
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,10 @@ def test_slc_deployer_generate_activation_command_failure(mock_lang_settings, co
allow_override=False)


def test_slc_deployer_get_language_activation(container_deployer, language_alias,
def test_slc_deployer_get_language_definition(container_deployer, language_alias,
container_file_name, container_bfs_path):
expected_command = f"{language_alias}=localzmq+protobuf:///{container_bfs_path}?" \
f"lang=python#/buckets/{container_bfs_path}/exaudf/exaudfclient_py3"

command = container_deployer.get_language_activation(container_file_name)
command = container_deployer.get_language_definition(container_file_name)
assert command == expected_command

0 comments on commit ceb4245

Please sign in to comment.