Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#136: Exasol SQLA client usage stopped working in certain scenarios #137

Merged
merged 27 commits into from
May 18, 2022
Merged

#136: Exasol SQLA client usage stopped working in certain scenarios #137

merged 27 commits into from
May 18, 2022

Conversation

Nicoretti
Copy link
Member

Fixes #136

@Nicoretti Nicoretti requested a review from tkilias May 12, 2022 14:42
@tkilias tkilias changed the title bug/#136 exasol sqla client usage stoped working in certain scenarios #136: Exasol SQLA client usage stopped working in certain scenarios May 16, 2022
Nicoretti added 23 commits May 16, 2022 09:54
@Nicoretti
Move odbc based get_foreign_keys to pyodbc dialect
20814e9
@Nicoretti
Addition fk refactoring
8fca316
@Nicoretti
Move the odbc based get_pk_constraint to pyodbc dialect
26fc0f2
@Nicoretti
Refactor _get_constraint_sql_str method
21f4457
@Nicoretti
Adjust deadlock tests and markers to take odbc refactoring into account
1b0279c
@Nicoretti
Move odbc based get_columns functionality to pyodbc dialect
24b29d3
@Nicoretti
Refactor get_column_sql_query_str method
320d947
@Nicoretti
Addition columns refactoring
700845a
@Nicoretti
Fix fallback checks
4c5adaf
@Nicoretti
Ensure test take into account the correct dialect
ccbec12
@Nicoretti
Refactor get_schema_names
f160052
@Nicoretti
Move get_table_names and has_table to pyodbc based dialaect
897b034
@Nicoretti
Move odbc based get_view_names to pyodbc dialect
8aefefb
@Nicoretti
Move odbc based get_view_definition to pyodbc based dialect
2641cbd
@Nicoretti
Remove use_sql_fallback method from base dialect
e12b6b0
@Nicoretti
Move getODBCConnection from based dialect to pyodbc dialect
c5d25a1
@Nicoretti
Move _get_tables_for_schema_odbc from base to pyodbc dialect
a89bd0a
@Nicoretti
Minor refactorings on Exasol base dialect
5fb3bd0
@Nicoretti
Remove unused variables/instructions
b88f056
@Nicoretti
Minor refactorings pyodbc based dialect
7ced605
@Nicoretti
Add missing cache annotation
17937e4
@Nicoretti
Fix bug #136
5dd460c
@Nicoretti
Minor refactorings to clean up the bug fix
107cffc
@Nicoretti Nicoretti force-pushed the bug/#136-exasol-sqla-client-usage-stoped-working-in-certain-scenarios branch from de06b36 to 107cffc Compare May 18, 2022 06:51
@Nicoretti Nicoretti mentioned this pull request May 18, 2022
Closed
3 tasks
tkilias
tkilias requested changes May 18, 2022
View reviewed changes
sqlalchemy_exasol/base.py Show resolved Hide resolved
sqlalchemy_exasol/pyodbc.py Show resolved Hide resolved
sqlalchemy_exasol/base.py Show resolved Hide resolved
sqlalchemy_exasol/pyodbc.py Show resolved Hide resolved
sqlalchemy_exasol/pyodbc.py Show resolved Hide resolved
@Nicoretti Nicoretti mentioned this pull request May 18, 2022
Open
@Nicoretti Nicoretti mentioned this pull request May 18, 2022
Closed
@Nicoretti Nicoretti requested a review from tkilias May 18, 2022 12:16
@Nicoretti Nicoretti merged commit 10371b5 into master May 18, 2022
@Nicoretti Nicoretti deleted the bug/#136-exasol-sqla-client-usage-stoped-working-in-certain-scenarios branch May 18, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkilias tkilias tkilias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exasol SQLA client usage stopped working in certain scenarios
2 participants
@Nicoretti @tkilias