-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#685: Update bazel #439
Merged
Merged
#685: Update bazel #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomuben
force-pushed
the
refactoring/685_update_bazel
branch
from
August 1, 2024 17:24
b1dcbae
to
d20a180
Compare
tomuben
force-pushed
the
refactoring/685_update_bazel
branch
from
August 6, 2024 17:51
098b8d9
to
e5843ad
Compare
tkilias
reviewed
Aug 7, 2024
tkilias
reviewed
Aug 7, 2024
tkilias
reviewed
Aug 7, 2024
tkilias
reviewed
Aug 7, 2024
tkilias
reviewed
Aug 7, 2024
tkilias
reviewed
Aug 7, 2024
tkilias
reviewed
Aug 7, 2024
flavors/template-Exasol-all-python-3.10-conda/flavor_base/build_deps/packages/conda_packages
Show resolved
Hide resolved
tkilias
reviewed
Aug 7, 2024
flavors/template-Exasol-all-python-3.10-conda/flavor_base/language_deps/packages/conda_packages
Outdated
Show resolved
Hide resolved
tkilias
reviewed
Aug 7, 2024
...ors/template-Exasol-all-python-3.10-conda/flavor_base/udfclient_deps/packages/conda_packages
Outdated
Show resolved
Hide resolved
tkilias
reviewed
Aug 7, 2024
...template-Exasol-all-python-3.10-cuda-conda/flavor_base/language_deps/packages/conda_packages
Outdated
Show resolved
Hide resolved
tkilias
reviewed
Aug 7, 2024
...emplate-Exasol-all-python-3.10-cuda-conda/flavor_base/udfclient_deps/packages/conda_packages
Outdated
Show resolved
Hide resolved
Removed direct dependency for: - _openmp_mutex - libblas Updated gxx_linux-64/gcc_linux-64
tkilias
requested changes
Aug 12, 2024
flavors/template-Exasol-all-python-3.10-conda/flavor_base/base_test_build_run/Dockerfile
Outdated
Show resolved
Hide resolved
flavors/template-Exasol-all-python-3.10-conda/flavor_base/build_deps/packages/conda_packages
Show resolved
Hide resolved
flavors/template-Exasol-all-python-3.10-conda/flavor_base/language_deps/packages/conda_packages
Show resolved
Hide resolved
tkilias
previously approved these changes
Aug 12, 2024
tomuben
commented
Aug 12, 2024
@@ -433,7 +433,7 @@ void JavaVMImpl::registerFunctions() { | |||
} | |||
|
|||
void JavaVMImpl::setClasspath() { | |||
m_exaJarPath = m_exaJavaPath + "/libexaudf.jar"; | |||
m_exaJarPath = m_exaJavaPath + "/exaudf_deploy.jar"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the Bazel docu this needs to be exaudf_deploy.jar
because otherwise the external dependencies (UDF API!!!) are missing. Not sure how this worked before, my best explanation: this is also a breaking change due to the new Bazel version.
tkilias
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to exasol/script-languages-release#685