Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace language-container deployer with the common implementation in python-extension-common #121

Merged
merged 7 commits into from
May 31, 2024

Conversation

Shmuma
Copy link
Contributor

@Shmuma Shmuma commented May 29, 2024

Closes #118

  • add dependency on python-extension-common
  • refactor the code to use it
  • implement tests
  • removed bucketfs_operations and exasol-bucketfs dep

@Shmuma Shmuma marked this pull request as ready for review May 30, 2024 07:22
@ahsimb
Copy link
Collaborator

ahsimb commented May 30, 2024

I am not sure the unit test is needed, as it practically replicates this test in the python-extension-common

@ahsimb
Copy link
Collaborator

ahsimb commented May 30, 2024

We should also change the documentation since we have new parameters in the cli. Plus the usual changelog.

@Shmuma
Copy link
Contributor Author

Shmuma commented May 30, 2024

I am not sure the unit test is needed, as it practically replicates this test in the python-extension-common

Yes, I used it for the inspiration, but unit test I added is working on a different level - we're checking the functionality of the subclass of the class provided by python-extension-common. As they are now live in separate repos/packages, superclass might change the behaviour without updating the subclass. The test is basic, but I think it is better than nothing

@Shmuma
Copy link
Contributor Author

Shmuma commented May 30, 2024

We should also change the documentation since we have new parameters in the cli. Plus the usual changelog.

Hm, what new parameter do you mean? I added no new parameters.

Good point about the changelog, will add.

@ahsimb
Copy link
Collaborator

ahsimb commented May 30, 2024

The new parameters are related to SaaS.

@Shmuma
Copy link
Contributor Author

Shmuma commented May 31, 2024

Created a separate task to update the documentation: #122

ahsimb
ahsimb previously approved these changes May 31, 2024
@Shmuma Shmuma merged commit 22e8743 into main May 31, 2024
3 checks passed
@Shmuma Shmuma deleted the refactor/py-ext branch May 31, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace language-container deployer with the common implementation in python-extension-common
2 participants