-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace language-container deployer with the common implementation in python-extension-common #121
Conversation
I am not sure the unit test is needed, as it practically replicates this test in the python-extension-common |
We should also change the documentation since we have new parameters in the cli. Plus the usual changelog. |
Yes, I used it for the inspiration, but unit test I added is working on a different level - we're checking the functionality of the subclass of the class provided by python-extension-common. As they are now live in separate repos/packages, superclass might change the behaviour without updating the subclass. The test is basic, but I think it is better than nothing |
Hm, what new parameter do you mean? I added no new parameters. Good point about the changelog, will add. |
The new parameters are related to SaaS. |
Created a separate task to update the documentation: #122 |
Closes #118